[PATCH] D49833: [clangd] Receive compilationDatabasePath in 'initialize' request

simark marked 2 inline comments as done. simark added a comment. Thanks, done. Repository: rL LLVM https://reviews.llvm.org/D49833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49833: [clangd] Receive compilationDatabasePath in 'initialize' request

This revision was automatically updated to reflect the committed changes. Closed by commit rL338518: [clangd] Receive compilationDatabasePath in 'initialize' request (authored by simark, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D49833: [clangd] Receive compilationDatabasePath in 'initialize' request

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM with a small nit. Thanks for the change! Comment at: clangd/ClangdLSPServer.cpp:419 +DidChangeConfigurationParams &Params) { + ClangdConfigurationPara

[PATCH] D49833: [clangd] Receive compilationDatabasePath in 'initialize' request

simark updated this revision to Diff 158366. simark added a comment. Address Ilya's comment (add an indirection for initializationOptions). Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49833 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/Protocol.cpp

[PATCH] D49833: [clangd] Receive compilationDatabasePath in 'initialize' request

simark added a comment. In https://reviews.llvm.org/D49833#1182615, @malaperle wrote: > @simark would you mind finishing this patch and committing it? I won't be > able to finish it given that I started it at a different company, etc. Yes, I'll take it over, thanks for getting it started. Re

[PATCH] D49833: [clangd] Receive compilationDatabasePath in 'initialize' request

malaperle added a comment. @simark would you mind finishing this patch and committing it? I won't be able to finish it given that I started it at a different company, etc. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49833 ___ cf

[PATCH] D49833: [clangd] Receive compilationDatabasePath in 'initialize' request

ilya-biryukov added a comment. In https://reviews.llvm.org/D49833#1181651, @malaperle wrote: > Was there any objection to this patch? It would have been nice to have this > before the branching. Sorry for the delay, somehow missed this update in my inbox. In https://reviews.llvm.org/D49833#11

[PATCH] D49833: [clangd] Receive compilationDatabasePath in 'initialize' request

malaperle added a comment. Was there any objection to this patch? It would have been nice to have this before the branching. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49833 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D49833: [clangd] Receive compilationDatabasePath in 'initialize' request

malaperle added a comment. In https://reviews.llvm.org/D49833#1176337, @ilya-biryukov wrote: > Not strictly opposed to this change, but is there any reason why the clients > can't guarantee they'll send didChangeConfiguration right after clangd is > initialized? LSP: > Until the server has r

[PATCH] D49833: [clangd] Receive compilationDatabasePath in 'initialize' request

ilya-biryukov added a comment. Not strictly opposed to this change, but should any reason why the clients can't guarantee they'll send didChangeConfiguration right after clangd is initialized? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49833

[PATCH] D49833: [clangd] Receive compilationDatabasePath in 'initialize' request

malaperle created this revision. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. That way, as soon as the "initialize" is received by the server, it can start parsing/indexing with a valid compilation database and not have to wait for a an initial 'didCha