[PATCH] D49808: [libc++] Factor duplicate code into function templates

2018-07-25 Thread Louis Dionne via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCXX337955: [libc++] Factor duplicate code into function templates (authored by ldionne, committed by ). Changed prior to commit: https://reviews.llvm.org/D49808?vs=157316&id=157340#toc Repository: rCX

[PATCH] D49808: [libc++] Factor duplicate code into function templates

2018-07-25 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. Nice cleanup! LGTM. Repository: rCXX libc++ https://reviews.llvm.org/D49808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D49808: [libc++] Factor duplicate code into function templates

2018-07-25 Thread Louis Dionne via Phabricator via cfe-commits
ldionne created this revision. ldionne added a reviewer: mclow.lists. Herald added a reviewer: EricWF. Herald added subscribers: cfe-commits, dexonsmith, christof. The exact same code was replicated 11 times for implementing the basic_istream input operators (those that don't use numeric_limits).