[PATCH] D49797: [clang-format] Indent after breaking Javadoc annotated line

This revision was automatically updated to reflect the committed changes. Closed by commit rL338232: [clang-format] Indent after breaking Javadoc annotated line (authored by krasimir, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D49797

[PATCH] D49797: [clang-format] Indent after breaking Javadoc annotated line

krasimir updated this revision to Diff 157925. krasimir added a comment. - Address comments Repository: rC Clang https://reviews.llvm.org/D49797 Files: lib/Format/BreakableToken.cpp lib/Format/BreakableToken.h lib/Format/ContinuationIndenter.cpp lib/Format/Format.cpp unittests/Form

[PATCH] D49797: [clang-format] Indent after breaking Javadoc annotated line

mprobst added inline comments. Comment at: lib/Format/Format.cpp:814 +// by qualified identifiers. +GoogleStyle.CommentPragmas = "(taze:|^/[ \t]*<|@see|@exports|@module|@mods)"; GoogleStyle.MaxEmptyLinesToKeep = 3; krasimir wrote: > mprobst wrote: >

[PATCH] D49797: [clang-format] Indent after breaking Javadoc annotated line

krasimir added inline comments. Comment at: lib/Format/Format.cpp:814 +// by qualified identifiers. +GoogleStyle.CommentPragmas = "(taze:|^/[ \t]*<|@see|@exports|@module|@mods)"; GoogleStyle.MaxEmptyLinesToKeep = 3; mprobst wrote: > `@exports` isn't

[PATCH] D49797: [clang-format] Indent after breaking Javadoc annotated line

mprobst accepted this revision. mprobst added inline comments. This revision is now accepted and ready to land. Comment at: lib/Format/Format.cpp:814 +// by qualified identifiers. +GoogleStyle.CommentPragmas = "(taze:|^/[ \t]*<|@see|@exports|@module|@mods)"; GoogleS

[PATCH] D49797: [clang-format] Indent after breaking Javadoc annotated line

krasimir marked an inline comment as done. krasimir added inline comments. Comment at: lib/Format/BreakableToken.cpp:526 + 0, Content[LineIndex].find_first_of(Blanks)); + if (FirstWord == "@param") +return Style.ContinuationIndentWidth; mprobst wrote: >

[PATCH] D49797: [clang-format] Indent after breaking Javadoc annotated line

krasimir updated this revision to Diff 157681. krasimir marked 3 inline comments as done. krasimir added a comment. - Address review comments Repository: rC Clang https://reviews.llvm.org/D49797 Files: lib/Format/BreakableToken.cpp lib/Format/BreakableToken.h lib/Format/ContinuationInd

[PATCH] D49797: [clang-format] Indent after breaking Javadoc annotated line

mprobst added inline comments. Comment at: unittests/Format/FormatTestComments.cpp:3109 +TEST_F(FormatTestComments, IndentsLongJavadocAnnotatedLines) { + FormatStyle Style = getGoogleStyle(FormatStyle::LK_Java); + Style.ColumnLimit = 60; mprobst wrote: > add a

[PATCH] D49797: [clang-format] Indent after breaking Javadoc annotated line

mprobst added inline comments. Comment at: lib/Format/BreakableToken.cpp:526 + 0, Content[LineIndex].find_first_of(Blanks)); + if (FirstWord == "@param") +return Style.ContinuationIndentWidth; Shouldn't this check the set above? Comme

[PATCH] D49797: [clang-format] Indent after breaking Javadoc annotated line

krasimir updated this revision to Diff 157452. krasimir added a comment. - Update tests Repository: rC Clang https://reviews.llvm.org/D49797 Files: lib/Format/BreakableToken.cpp lib/Format/BreakableToken.h lib/Format/ContinuationIndenter.cpp unittests/Format/FormatTestComments.cpp

[PATCH] D49797: [clang-format] Indent after breaking Javadoc annotated line

krasimir created this revision. Herald added subscribers: cfe-commits, acoomans. This patch makes clang-format indent the subsequent lines created by breaking a long javadoc annotated line. Repository: rC Clang https://reviews.llvm.org/D49797 Files: lib/Format/BreakableToken.cpp lib/Form