[PATCH] D49724: [VFS] Cleanups to VFS interfaces.

2018-07-25 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. For the record: this got reverted in https://reviews.llvm.org/rL337850 Repository: rL LLVM https://reviews.llvm.org/D49724 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[PATCH] D49724: [VFS] Cleanups to VFS interfaces.

2018-07-24 Thread Jordan Rupprecht via Phabricator via cfe-commits
rupprecht added a comment. Looks like this caused some test failures (http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick/builds/14441/steps/ninja%20check%201), e.g.: [ RUN ] GoToInclude.All /home/buildslave/buildslave/clang-cmake-aarch64-quick/llvm/tools/clang/tools/extra/uni

[PATCH] D49724: [VFS] Cleanups to VFS interfaces.

2018-07-24 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL337834: [VFS] Cleanups to VFS interfaces. (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D49724 Files: cfe/trunk/includ

[PATCH] D49724: [VFS] Cleanups to VFS interfaces.

2018-07-24 Thread Manuel Klimek via Phabricator via cfe-commits
klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D49724 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[PATCH] D49724: [VFS] Cleanups to VFS interfaces.

2018-07-24 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: klimek. Herald added a subscriber: cfe-commits. - add comments clarifying semantics - Status::copyWithNewName(Status, Name) --> instance method - Status::copyWithNewName(fs::file_status, Name) --> constructor (it's not a copy) - File::g