This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL337833: [CMake] Fix the setting of LIBCXX_HEADER_DIR in
standalone build (authored by phosek, committed by ).
Herald added
phosek updated this revision to Diff 157050.
Repository:
rCXX libc++
https://reviews.llvm.org/D49711
Files:
libcxx/CMakeLists.txt
libcxx/cmake/Modules/HandleLibCXXABI.cmake
Index: libcxx/cmake/Modules/HandleLibCXXABI.cmake
=
mclow.lists added a comment.
> phosek updated this revision to Diff 157043.
This fixes the problem with copying all the include files.
This *also* fixes my broken build (that was broken by r337630 wanting to copy
`cxxabi.h` to `/include/c++/v1/`).
LG for my configuration.
Repository:
rCXX l
phosek updated this revision to Diff 157043.
Repository:
rCXX libc++
https://reviews.llvm.org/D49711
Files:
libcxx/CMakeLists.txt
libcxx/cmake/Modules/HandleLibCXXABI.cmake
Index: libcxx/cmake/Modules/HandleLibCXXABI.cmake
=
mclow.lists added a comment.
Testing this on my system (Mac OS 10.13.6, using system libc++abi), I get a lot
of files in my build's `include/c++/v1` folder. Previously, there were two
(`__cxxabi_config.h` and`ccxxabi.h`).
Now there are 131 files - all the libc++ header files.
Why?
The cmake co
ldionne added a comment.
LGTM. FWIW, I'm really not a huge fan of all these different ways of building
libc++. There should be one canonical way of doing it, and it should be simple.
However, it seems like this patch is the right thing to do given the changes
that have already been made to acco
phosek added a comment.
I've tested this on macOS and everything seems to be working,
Repository:
rCXX libc++
https://reviews.llvm.org/D49711
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
aheejin added a comment.
This fixes our local waterfall build failure. Thank you!
Repository:
rCXX libc++
https://reviews.llvm.org/D49711
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
phosek created this revision.
phosek added reviewers: EricWF, ldionne, aheejin, arphaman.
Herald added subscribers: cfe-commits, christof, mgorny.
This is an alternative approach to r337727 which broke the build
because libc++ headers were copied into the location outside of
directories used by Cl
