This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339011: [clangd] Index Interfaces for Xrefs (authored by
hokein, committed by ).
Herald added a subscriber: llvm-commits.
hokein updated this revision to Diff 159287.
hokein marked 2 inline comments as done.
hokein added a comment.
Rebase
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49658
Files:
clangd/index/FileIndex.cpp
clangd/index/FileIndex.h
clangd/index/Index.h
clangd/index/MemInde
hokein marked 2 inline comments as done.
hokein added inline comments.
Comment at: clangd/index/Index.h:288
+ Unknown = 0,
+ Declaration = static_cast(index::SymbolRole::Declaration),
+ Definition = static_cast(index::SymbolRole::Definition),
ilya-biryukov wro
ilya-biryukov added a comment.
Picking it up since @sammccall is OOO.
> Implementing all index operations in the patch would be end up with a large
> patch, I intend to split the patch as small as possible. Let's scope this
> patch to interface only.
LG as interface-only patch. just a few nits
hokein added a comment.
In https://reviews.llvm.org/D49658#1171410, @sammccall wrote:
> Mostly LG.
>
> I think we can simplify in a couple of places, and you should decide if this
> patch is *implementing* the new index operation or not. (Currently it
> implements it for 1/3 implementations, wh
hokein updated this revision to Diff 158507.
hokein marked 4 inline comments as done.
hokein added a comment.
Scope the patch to interfaces only.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49658
Files:
clangd/index/FileIndex.cpp
clangd/index/FileIndex.h
clangd/index/I
sammccall added a comment.
Mostly LG.
I think we can simplify in a couple of places, and you should decide if this
patch is *implementing* the new index operation or not. (Currently it
implements it for 1/3 implementations, which doesn't seem that useful).
Comment at: clangd
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: arphaman, jkorous, MaskRay, ioeric, ilya-biryukov.
This is the first step of implementing Xrefs in clangd:
- add index interfaces, and related data structures.
- implement a naive in-memory index for symbo
