[PATCH] D49629: [CMake] Fix the setting of LIBCXX_HEADER_DIR

2018-07-23 Thread Heejin Ahn via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL337727: [CMake] Fix the setting of LIBCXX_HEADER_DIR (authored by aheejin, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D49629 Files: libcxx/

[PATCH] D49629: [CMake] Fix the setting of LIBCXX_HEADER_DIR

2018-07-23 Thread Petr Hosek via Phabricator via cfe-commits
phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rCXX libc++ https://reviews.llvm.org/D49629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

[PATCH] D49629: [CMake] Fix the setting of LIBCXX_HEADER_DIR

2018-07-23 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin added a comment. Ping Repository: rCXX libc++ https://reviews.llvm.org/D49629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49629: [CMake] Fix the setting of LIBCXX_HEADER_DIR

2018-07-23 Thread Keith Walker via Phabricator via cfe-commits
keith.walker.arm added a comment. This change fixed a failing build here, so it looks correct to me. Repository: rCXX libc++ https://reviews.llvm.org/D49629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[PATCH] D49629: [CMake] Fix the setting of LIBCXX_HEADER_DIR

2018-07-20 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin added a comment. This line was added in https://reviews.llvm.org/rL335809, and after https://reviews.llvm.org/rL337630 `dst` in this line is set to NULL in our

[PATCH] D49629: [CMake] Fix the setting of LIBCXX_HEADER_DIR

2018-07-20 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin created this revision. aheejin added a reviewer: phosek. Herald added subscribers: cfe-commits, ldionne, christof, mgorny. Repository: rCXX libc++ https://reviews.llvm.org/D49629 Files: CMakeLists.txt Index: CMakeLists.txt ===