This revision was automatically updated to reflect the committed changes.
Closed by commit rL337477: [libc++] Allow running ABI list tests with different
ABI versions (authored by ldionne, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49509?vs=156148&id=156323#toc
Reposito
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. Though it might be worth noting that we don't really have an "ABI v2"
yet; we're just staging it ATM.
Repository:
rL LLVM
https://reviews.llvm.org/D49509
_
ldionne added a comment.
In https://reviews.llvm.org/D49509#1168084, @ldionne wrote:
> In https://reviews.llvm.org/D49509#1167500, @smeenai wrote:
>
> > This went out to llvm-commits. You may wanna re-upload with cfe-commits
> > added instead.
>
>
> Ah! That uncovers a deeper problem -- the inst
ldionne edited subscribers, added: cfe-commits; removed: llvm-commits.
ldionne added a comment.
In https://reviews.llvm.org/D49509#1167500, @smeenai wrote:
> This went out to llvm-commits. You may wanna re-upload with cfe-commits added
> instead.
Ah! That uncovers a deeper problem -- the instr