[PATCH] D49476: [Index] Set OrigD before D is changed.

This revision was automatically updated to reflect the committed changes. Closed by commit rL337529: [Index] Set OrigD before D is changed. (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D49476 Files: cfe/trunk/lib/

[PATCH] D49476: [Index] Set OrigD before D is changed.

akyrtzi accepted this revision. akyrtzi added a comment. This revision is now accepted and ready to land. Good enough, thanks for looking into this! Repository: rC Clang https://reviews.llvm.org/D49476 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D49476: [Index] Set OrigD before D is changed.

ioeric added a comment. In https://reviews.llvm.org/D49476#1168604, @akyrtzi wrote: > `CXIndexDataConsumer.cpp` uses `ASTNode.OrigD`, that code is exercised when > you run `c-index-test -index-file <...>`. I'd recommend to at least check if > that command would produce a different output for th

[PATCH] D49476: [Index] Set OrigD before D is changed.

ioeric updated this revision to Diff 156356. ioeric added a comment. - try to add a test case. Repository: rC Clang https://reviews.llvm.org/D49476 Files: lib/Index/IndexingContext.cpp test/Index/index-template-specialization.cpp tools/c-index-test/c-index-test.c tools/libclang/Index

[PATCH] D49476: [Index] Set OrigD before D is changed.

akyrtzi added a comment. `CXIndexDataConsumer.cpp` uses `ASTNode.OrigD`, that code is exercised when you run `c-index-test -index-file <...>`. I'd recommend to at least check if that command would produce a different output for the test case that you detected originally. Repository: rC Clan

[PATCH] D49476: [Index] Set OrigD before D is changed.

ioeric added a comment. In https://reviews.llvm.org/D49476#1167294, @akyrtzi wrote: > Is it possible to add a regression test case ? I assume this is fixing some > issue, we should make sure we don't regress again. This fixes a downstream use case where we use `OrigD`. AFAICT, `c-index-test`

[PATCH] D49476: [Index] Set OrigD before D is changed.

akyrtzi added a comment. Is it possible to add a regression test case ? I assume this is fixing some issue, we should make sure we don't regress again. Repository: rC Clang https://reviews.llvm.org/D49476 ___ cfe-commits mailing list cfe-commits

[PATCH] D49476: [Index] Set OrigD before D is changed.

ioeric created this revision. ioeric added reviewers: akyrtzi, arphaman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D49476 Files: lib/Index/IndexingContext.cpp Index: lib/Index/IndexingContext.cpp ==