This revision was automatically updated to reflect the committed changes.
Closed by commit rC337275: [ASTImporter] Fix poisonous structural equivalence
cache (authored by martong, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49300?vs=155858&id=155863#toc
Repository:
rC
martong updated this revision to Diff 155858.
martong added a comment.
- Add comment about structural eq and BFS
Repository:
rC Clang
https://reviews.llvm.org/D49300
Files:
include/clang/AST/ASTStructuralEquivalence.h
lib/AST/ASTImporter.cpp
lib/AST/ASTStructuralEquivalence.cpp
lib/S
martong added a comment.
@a_sidorin
Ok, thanks Aleksei for the review. I added the explanation as file comments
into `StructuralEquivalence.cpp`.
Repository:
rC Clang
https://reviews.llvm.org/D49300
___
cfe-commits mailing list
cfe-commits@list
a_sidorin accepted this revision.
a_sidorin added a comment.
This revision is now accepted and ready to land.
Hi Gabor,
Thank you for this explanation, it sounds reasonable. Ithink it should be
placed into the commit message or into the comment somewhere.
Repository:
rC Clang
https://review
martong added a comment.
Hi Aleksei,
Unfortunately, it seems that it is very to hard synthesize a lit or unit test
for this fix.
I have found this flaw during the CTU analysis of Bitcoin, where the AST was
immense.
Because of the lack of tests, now I am trying to persuade you based on some
th
a_sidorin added a comment.
Hi Gabor,
Could you provide some tests for the issue?
Repository:
rC Clang
https://reviews.llvm.org/D49300
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
martong created this revision.
martong added reviewers: a.sidorin, a_sidorin, r.stahl.
Herald added subscribers: cfe-commits, dkrupp, rnkovacs.
Implementation functions call into the member functions of
ASTStructuralEquivalence, thus they can falsely alter the DeclsToCheck state
(they add decls).
