simark added inline comments.
Comment at: lib/Basic/FileManager.cpp:395
+ SmallString<128> RealPathName;
+ if (!FS->getRealPath(InterndFileName, RealPathName))
+UFE->RealPathName = RealPathName.str();
ioeric wrote:
> simark wrote:
> > ioeric wrote:
> > > It
simark added a comment.
In https://reviews.llvm.org/D49197#1159704, @ioeric wrote:
> In https://reviews.llvm.org/D49197#1158972, @simark wrote:
>
> > Background: I'm trying to fix the cases why we receive a FileEntry without
> > a real path computed in clangd, so we can avoid having to compute
ioeric added a comment.
In https://reviews.llvm.org/D49197#1158972, @simark wrote:
> Background: I'm trying to fix the cases why we receive a FileEntry without a
> real path computed in clangd, so we can avoid having to compute it ourselves.
I'm curious how you use `getVirtualFile` in your cl
simark added inline comments.
Comment at: lib/Basic/FileManager.cpp:395
+ SmallString<128> RealPathName;
+ if (!FS->getRealPath(InterndFileName, RealPathName))
+UFE->RealPathName = RealPathName.str();
ioeric wrote:
> It seems that at this point, we have fai
ioeric added inline comments.
Comment at: lib/Basic/FileManager.cpp:395
+ SmallString<128> RealPathName;
+ if (!FS->getRealPath(InterndFileName, RealPathName))
+UFE->RealPathName = RealPathName.str();
It seems that at this point, we have failed to find `Fil
simark added a comment.
Background: I'm trying to fix the cases why we receive a FileEntry without a
real path computed in clangd, so we can avoid having to compute it ourselves.
Repository:
rC Clang
https://reviews.llvm.org/D49197
___
cfe-comm
simark added a comment.
I'm not sure who should review this patch, please add anybody you think is
qualified/responsible.
Repository:
rC Clang
https://reviews.llvm.org/D49197
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
simark updated this revision to Diff 155027.
simark added a comment.
Update commit message.
Repository:
rC Clang
https://reviews.llvm.org/D49197
Files:
lib/Basic/FileManager.cpp
unittests/Basic/FileManagerTest.cpp
Index: unittests/Basic/FileManagerTest.cpp
=
simark created this revision.
Herald added a subscriber: cfe-commits.
I noticed that when getVirtualFile is called for a file, subsequent
calls to getFile will return a FileEntry without the RealPathName
computed:
const FileEntry *VFE = Mgr->getVirtualFile("/foo/../bar", ...);
const FileEntry
