This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX337824: Stop wrapping __has_include in another macro
(authored by arichardson, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49067?vs=154566&id=157011#toc
Repository:
rL LLVM
This revision was automatically updated to reflect the committed changes.
Closed by commit rL337824: Stop wrapping __has_include in another macro
(authored by arichardson, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D49067
Files:
lib
mclow.lists accepted this revision.
mclow.lists added inline comments.
This revision is now accepted and ready to land.
Comment at: include/__config:153
+#ifndef __has_include
+#define __has_include(...) 0
#endif
rsmith wrote:
> arichardson wrote:
> > EricWF wro
rsmith added inline comments.
Comment at: include/__config:153
+#ifndef __has_include
+#define __has_include(...) 0
#endif
arichardson wrote:
> EricWF wrote:
> > I do prefer not hijacking this name, but if it's needed to make things
> > work, then it's OK with
arichardson added a comment.
In https://reviews.llvm.org/D49067#1172500, @EricWF wrote:
> Where are the special lexing rules specified?
In https://bugs.llvm.org/show_bug.cgi?id=37990#c1 @rsmith wrote:
> The C++ standard appears to be missing a rule that says that a __has_include
> token pr
EricWF added a reviewer: mclow.lists.
EricWF added a subscriber: mclow.lists.
EricWF added a comment.
Where are the special lexing rules specified?
Comment at: include/__config:153
+#ifndef __has_include
+#define __has_include(...) 0
#endif
I do prefer not hij
arichardson added a comment.
Ping?
Repository:
rCXX libc++
https://reviews.llvm.org/D49067
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arichardson created this revision.
arichardson added reviewers: EricWF, rsmith.
Herald added subscribers: cfe-commits, ldionne, christof.
This is not guaranteed to work since the characters after '__has_include('
have special lexing rules that can't possibly be applied when
__has_include is genera
