This revision was automatically updated to reflect the committed changes.
Closed by commit rL337103: Add caching when looking up coroutine_traits
(authored by modocache, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D48981
Files:
cfe/t
modocache accepted this revision.
modocache added a comment.
This revision is now accepted and ready to land.
Yup, LGTM! I'll land this now.
Repository:
rC Clang
https://reviews.llvm.org/D48981
___
cfe-commits mailing list
cfe-commits@lists.llvm.
tks2103 added a comment.
ping @modocache @GorNishanov
Repository:
rC Clang
https://reviews.llvm.org/D48981
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tks2103 added a comment.
ping @modocache @GorNishanov
Repository:
rC Clang
https://reviews.llvm.org/D48981
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
modocache resigned from this revision.
modocache added a comment.
This LGTM but I'll just wait for @GorNishanov to accept the patch, just in case
I'm missing something. I'd be happy to commit this for you once Gor accepts! :)
Repository:
rC Clang
https://reviews.llvm.org/D48981
__
tks2103 created this revision.
tks2103 added reviewers: GorNishanov, modocache.
Currently clang looks up the coroutine_traits ClassTemplateDecl
everytime it looks up the promise type. This is unnecessary
as coroutine_traits doesn't change between promise type lookups.
This diff caches the corouti
