[PATCH] D48921: NFC - Typo fix in test/CodeGenCXX/runtime-dllstorage.cpp

2019-12-12 Thread Gabor Buella via Phabricator via cfe-commits
GBuella added a comment. In D48921#1781447 , @thakis wrote: > This breaks the test everywhere, e.g. http://45.33.8.238/linux/5543/step_7.txt > > Can you revert this while you investigate if the test was broken since it > landed or if something broke it la

[PATCH] D48921: NFC - Typo fix in test/CodeGenCXX/runtime-dllstorage.cpp

2019-12-12 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. This breaks the test everywhere, e.g. http://45.33.8.238/linux/5543/step_7.txt Can you revert this while you investigate if the test was broken since it landed or if something broke it later, while it wasn't really testing what it was supposed to test? Repository: rG

[PATCH] D48921: NFC - Typo fix in test/CodeGenCXX/runtime-dllstorage.cpp

2019-12-12 Thread Gabor Buella via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG9c48c2f9c477: [NFC] - Typo fix in test/CodeGenCXX/runtime-dllstorage.cpp (authored by GBuella). Changed prior to commit: https://reviews.llvm.org/D48921?vs=154067&id=233543#toc Repository: rG LLVM Gi

[PATCH] D48921: NFC - Typo fix in test/CodeGenCXX/runtime-dllstorage.cpp

2019-12-11 Thread Jim Lin via Phabricator via cfe-commits
Jim accepted this revision. Jim added a comment. This revision is now accepted and ready to land. Herald added a project: clang. Are you ready to land this patch? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48921/new/ https://reviews.llvm.org/D48921