Hahnfeld added a comment.
I fixed `linux-header-search.cpp` by adding `-stdlib=libstdc++` in r338360
because I was seeing the same failure and that's what agreed to do in these
cases. If you can verify that it fixes your problems, I think it's safe to add
`-rtlib=libgcc` to the other test.
Re
phosek added a comment.
This has been breaking our bots since it has landed (both Linux and macOS
ones), here's a log:
https://logs.chromium.org/v/?s=fuchsia%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8939527016533487696%2F%2B%2Fsteps%2Fclang%2F0%2Fsteps%2Fcheck-clang%2F0%2Fstdout
In our Clan
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338294: [OpenEmbedded] Fix lib paths for OpenEmbedded
targets (authored by mgrang, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D48862?vs=15
mgrang added a comment.
I would commit this today unless there any comments. Thanks.
https://reviews.llvm.org/D48862
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgrang added a comment.
@rsmith Could you please take a look at the updated patch? I would like to
commit this. Thanks.
https://reviews.llvm.org/D48862
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
mgrang updated this revision to Diff 157391.
mgrang added a comment.
Rebased patch and fixed unit test on Windows.
https://reviews.llvm.org/D48862
Files:
lib/Driver/ToolChains/Gnu.cpp
lib/Driver/ToolChains/Linux.cpp
test/Driver/Inputs/openembedded_aarch64_linux_tree/usr/include/c++/6.3.0
mgrang updated this revision to Diff 157106.
mgrang added a comment.
Thanks @rsmith. I have addressed your comments.
https://reviews.llvm.org/D48862
Files:
lib/Driver/ToolChains/Gnu.cpp
lib/Driver/ToolChains/Linux.cpp
test/Driver/Inputs/openembedded_aarch64_linux_tree/usr/include/c++/6.3
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Driver/ToolChains/Gnu.cpp:2205-2209
+
+ // Deal with OpenEmbedded linux sysroots (like for arm-oe-linux-gnueabi)
+ // which are of the form /usr
mgrang added a comment.
Ping 3 for reviews please.
https://reviews.llvm.org/D48862
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgrang added a comment.
Ping 2 for reviews please.
https://reviews.llvm.org/D48862
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
10 matches
Mail list logo