This revision was automatically updated to reflect the committed changes.
Closed by commit rC335993: [Fixed Point Arithmetic] Rename `-fsame-fbits` flag
(authored by leonardchan, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D48727
Files:
include/clang/Basic/LangOptions.def
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D48727#1146873, @leonardchan wrote:
> Oh, having the same number of fractional bits is what leads to unsigned types
> having one bit of padding, and vice versa.
leonardchan added a comment.
Oh, having the same number of fractional bits is what leads to unsigned types
having one bit of padding, and vice versa.
If this flag is set to false, then the integral and fractional parts of the
unsigned types take up the whole bit width of the underlying scaled i
rjmccall added a comment.
This all looks reasonable except that I think the interpretation is exactly
backwards, no? From the documentation on the option,
`-fpadding-on-unsigned-fixed-point` causes there to be padding, i.e. the
inverse of the old `SameFBits`; but the default value, comments, a
leonardchan updated this revision to Diff 153335.
leonardchan added a comment.
Formatting and forgot to get rid of `Group` and `Flags`
Repository:
rC Clang
https://reviews.llvm.org/D48727
Files:
include/clang/Basic/LangOptions.def
include/clang/Basic/TargetInfo.h
include/clang/Driver/C
leonardchan created this revision.
leonardchan added reviewers: phosek, mcgrathr, jakehehrlich, rjmccall, ebevhan,
rsmith.
leonardchan added a project: clang.
- Rename the `-fsame-fbits` flag to `-fpadding-on-unsigned-fixed-point`
- Move the flag from a driver option to a cc1 option
- Rename the
