benhamilton accepted this revision.
benhamilton added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D48716#1149293, @jolesiak wrote:
> General comment to changes https://reviews.llvm.org/D48716,
> https://reviews.llvm.org/D48718, https://reviews.llvm.org
jolesiak updated this revision to Diff 153689.
jolesiak added a comment.
Fix grammar mistakes.
Repository:
rC Clang
https://reviews.llvm.org/D48716
Files:
lib/Format/FormatToken.h
lib/Format/TokenAnnotator.cpp
Index: lib/Format/TokenAnnotator.cpp
===
jolesiak marked 6 inline comments as done.
jolesiak added a comment.
In https://reviews.llvm.org/D48716#1146796, @benhamilton wrote:
> > Count selector parts also for method declarations.
>
> What bug does this fix? Can you add a test which breaks before this change
> and is fixed by this change
jolesiak marked 6 inline comments as done.
jolesiak added inline comments.
Comment at: lib/Format/FormatToken.h:247-248
+ /// If this is the first ObjC selector name in an ObjC method
+ /// definition or call, this contains the number of parts that whole selector
+ /// consist
benhamilton requested changes to this revision.
benhamilton added a comment.
This revision now requires changes to proceed.
> Count selector parts also for method declarations.
What bug does this fix? Can you add a test which breaks before this change and
is fixed by this change?
jolesiak updated this revision to Diff 153298.
jolesiak added a comment.
Fix comment
Repository:
rC Clang
https://reviews.llvm.org/D48716
Files:
lib/Format/FormatToken.h
lib/Format/TokenAnnotator.cpp
Index: lib/Format/TokenAnnotator.cpp
=
jolesiak created this revision.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D48716
Files:
lib/Format/FormatToken.h
lib/Format/TokenAnnotator.cpp
Index: lib/Format/TokenAnnotator.cpp
