NoQ closed this revision.
NoQ added a comment.
Committed as https://reviews.llvm.org/rC338436 but Phabricator didn't pick it
up because i put a `.` after the phabricator link.
https://reviews.llvm.org/D48681
___
cfe-commits mailing list
cfe-commits
NoQ updated this revision to Diff 155091.
NoQ added a comment.
Address my own comments.
https://reviews.llvm.org/D48681
Files:
include/clang/Analysis/CFG.h
include/clang/Analysis/ConstructionContext.h
lib/Analysis/CFG.cpp
lib/Analysis/ConstructionContext.cpp
lib/StaticAnalyzer/Core/Ex
NoQ added inline comments.
Comment at: lib/Analysis/ConstructionContext.cpp:186
+isa(TopLayer->getTriggerStmt())) {
+ return create(
+ C, cast(TopLayer->getTriggerStmt()), TopLayer->getIndex(),
Should assert that we only have one layer.
Re
NoQ added inline comments.
Comment at: include/clang/Analysis/ConstructionContext.h:90
assert(Other);
return (Trigger == Other->Trigger);
}
Uhm. Will fix.
Repository:
rC Clang
https://reviews.llvm.org/D48681
__
NoQ added inline comments.
Comment at: lib/Analysis/CFG.cpp:5011
print_initializer(OS, Helper, SICC->getCXXCtorInitializer());
-break;
+return;
}
For consistency.
Comment at: lib/Analysis/CFG.cpp:5074-5078
for (auto I: Stmts)
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet,
rnkovacs.
Herald added subscribers: cfe-commits, mikhail.ramalho, baloghadamsoftware.
Replace stubs we had to discriminate between temporaries and function arguments
with actual constructio
