This revision was automatically updated to reflect the committed changes.
Closed by commit rC335774: [HIP] Fix ordering of device-libs linking (authored
by aaronenyeshi, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48667?vs=153154&id=153158#toc
Repository:
rC Clang
htt
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
https://reviews.llvm.org/D48667
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
ashi1 updated this revision to Diff 153154.
ashi1 added a comment.
Updated diff with a lit test.
https://reviews.llvm.org/D48667
Files:
lib/Driver/ToolChains/HIP.cpp
test/Driver/hip-device-libs.hip
Index: test/Driver/hip-device-libs.hip
yaxunl added a comment.
Please add a lit test.
Repository:
rC Clang
https://reviews.llvm.org/D48667
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
b-sumner added a comment.
Thanks, looks good.
Repository:
rC Clang
https://reviews.llvm.org/D48667
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ashi1 created this revision.
ashi1 added reviewers: yaxunl, b-sumner.
ashi1 added projects: clang, AMDGPU.
Herald added a subscriber: cfe-commits.
Should link the bitcodes with caller functions before callee functions.
Repository:
rC Clang
https://reviews.llvm.org/D48667
Files:
lib/Driver/
