[PATCH] D48571: improve diagnostics for missing 'template' keyword

2018-06-26 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC335687: Diagnose missing 'template' keywords in more cases. (authored by rsmith, committed by ). Repository: rC Clang https://reviews.llvm.org/D48571 Files: include/clang/Basic/BitmaskEnum.h inclu

[PATCH] D48571: improve diagnostics for missing 'template' keyword

2018-06-26 Thread David Blaikie via Phabricator via cfe-commits
dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks pretty good to me - nice work! Repository: rL LLVM https://reviews.llvm.org/D48571 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D48571: improve diagnostics for missing 'template' keyword

2018-06-26 Thread Krzysztof Parzyszek via Phabricator via cfe-commits
kparzysz added a comment. Please take over, I commandeered to restore the patch. Repository: rL LLVM https://reviews.llvm.org/D48571 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D48571: improve diagnostics for missing 'template' keyword

2018-06-26 Thread Krzysztof Parzyszek via Phabricator via cfe-commits
kparzysz updated this revision to Diff 152946. kparzysz added a comment. Restored the original patch. Repository: rL LLVM https://reviews.llvm.org/D48571 Files: include/clang/Basic/BitmaskEnum.h include/clang/Parse/Parser.h include/clang/Parse/RAIIObjectsForParser.h include/clang/Sem

[PATCH] D48571: improve diagnostics for missing 'template' keyword

2018-06-26 Thread Krzysztof Parzyszek via Phabricator via cfe-commits
kparzysz reopened this revision. kparzysz added a comment. This needs to be restored to the original form. A mistake in a commit message closed this review by accident. Repository: rL LLVM https://reviews.llvm.org/D48571 ___ cfe-commits mailing

[PATCH] D48571: improve diagnostics for missing 'template' keyword

2018-06-26 Thread Brendon Cahoon via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL335641: [Hexagon] Add a "generic" cpu (authored by bcahoon, committed by ). Herald added a subscriber: llvm-commits. Chan

[PATCH] D48571: improve diagnostics for missing 'template' keyword

2018-06-25 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith created this revision. rsmith added a reviewer: dblaikie. Herald added a subscriber: eraman. We track when we see a name-shaped expression followed by a `<` token that we parse as a comparison. Then: - if we see a token sequence that cannot possibly be an expression but can be a template