[PATCH] D48562: [clangd] XPC transport layer

2018-08-08 Thread Jan Korous via Phabricator via cfe-commits
jkorous abandoned this revision. jkorous added a comment. We decided to go with a different solution: https://reviews.llvm.org/D50452 https://reviews.llvm.org/D48562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

[PATCH] D48562: [clangd] XPC transport layer

2018-07-20 Thread Jan Korous via Phabricator via cfe-commits
jkorous added a comment. BTW Just for the record - I put the rebased & updated patch here: [clangd] XPC WIP https://reviews.llvm.org/D49548 https://reviews.llvm.org/D48562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

[PATCH] D48562: [clangd] XPC transport layer

2018-07-19 Thread Jan Korous via Phabricator via cfe-commits
jkorous marked 7 inline comments as done. jkorous added inline comments. Comment at: xpc/test-client/ClangdXPCTestClient.cpp:51 + dlHandle, "clangd_xpc_get_bundle_identifier"); + xpc_connection_t conn = + xpc_connection_create(clangd_xpc_get_bundle_identifier(), NU

[PATCH] D48562: [clangd] XPC transport layer

2018-07-17 Thread Jan Korous via Phabricator via cfe-commits
jkorous added a reviewer: sammccall. jkorous added a comment. Hi Sam, I am definitely open to discussion about the right abstraction. I will push patches rebased on TOT and changes based on your comments today or tomorrow and I am trying to figure out how could we use your Transport abstraction

[PATCH] D48562: [clangd] XPC transport layer

2018-07-16 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Just an initial couple of thoughts here, haven't yet been through in detail. Mostly I wonder if we can use slightly different abstractions in https://reviews.llvm.org/D48559 to so the JSON/XPC parts get the code reuse we want but the work required to call one vs the o

[PATCH] D48562: [clangd] XPC transport layer

2018-07-13 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added inline comments. Herald added a subscriber: dexonsmith. Comment at: xpc/test-client/ClangdXPCTestClient.cpp:51 + dlHandle, "clangd_xpc_get_bundle_identifier"); + xpc_connection_t conn = + xpc_connection_create(clangd_xpc_get_bundle_identifier(), NULL

[PATCH] D48562: [clangd] XPC transport layer

2018-06-26 Thread Jan Korous via Phabricator via cfe-commits
jkorous updated this revision to Diff 152888. jkorous added a comment. Two changes in test client based on internal review by XPC folks: - Removed cleanup code at the end of main() as dispatch_main() never returns. - Removed check for conn as xpc_connection_create() is guaranteed to succeed. ht

[PATCH] D48562: [clangd] XPC transport layer

2018-06-26 Thread Jan Korous via Phabricator via cfe-commits
jkorous added inline comments. Comment at: xpc/test-client/ClangdXPCTestClient.cpp:51 + dlHandle, "clangd_xpc_get_bundle_identifier"); + xpc_connection_t conn = + xpc_connection_create(clangd_xpc_get_bundle_identifier(), NULL); arphaman wrote: > We

[PATCH] D48562: [clangd] XPC transport layer

2018-06-25 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added inline comments. Comment at: xpc/test-client/ClangdXPCTestClient.cpp:51 + dlHandle, "clangd_xpc_get_bundle_identifier"); + xpc_connection_t conn = + xpc_connection_create(clangd_xpc_get_bundle_identifier(), NULL); We should probably

[PATCH] D48562: [clangd] XPC transport layer

2018-06-25 Thread Jan Korous via Phabricator via cfe-commits
jkorous created this revision. jkorous added a project: clang-tools-extra. Herald added subscribers: cfe-commits, MaskRay, ioeric, ilya-biryukov, mgorny. Implementation of alternative transport layer for macOS based on XPC. Based on these two other patches: https://reviews.llvm.org/D48559 https:/