jkorous added a comment.
BTW Just for the record - I put the rebased & updated patch here: [clangd] XPC
WIP https://reviews.llvm.org/D49548
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48560
___
cfe-commits mailing list
cfe-commi
jkorous marked 12 inline comments as done.
jkorous added inline comments.
Comment at: xpc/XPCJSONConversions.cpp:62
+ if (objType == XPC_TYPE_UINT64)
+return json::Expr(xpc_uint64_get_value(xpcObj));
+ if (objType == XPC_TYPE_STRING)
sammccall wrote:
> hmm,
jkorous marked an inline comment as done.
jkorous added a comment.
Hi Sam, no worries! Thanks for making time to take a look! I am going to rebase
all my patches on top of JSON library moved to llvm/Support and process your
comments.
Comment at: clangd/xpc/CMakeLists.txt:1
+s
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Sorry it took so long for these to get attention.
Starting here because it's simple and helps me understand the bigger patches
This one looks good, really just nits.
===
jkorous created this revision.
jkorous added a project: clang-tools-extra.
Herald added subscribers: cfe-commits, MaskRay, ioeric, ilya-biryukov, mgorny.
This is a self-contained pair of utility functions for the XPC transport layer.
It's not dependent on but following the refactoring patch:
http
