This revision was automatically updated to reflect the committed changes.
Closed by commit rL335305: Ignore blacklist when generating __cfi_check_fail.
(authored by eugenis, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D48454?vs=1523
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D48454
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
eugenis added a comment.
Yes, that's better.
https://reviews.llvm.org/D48454
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
eugenis updated this revision to Diff 152395.
eugenis added a comment.
Simplify code.
https://reviews.llvm.org/D48454
Files:
clang/lib/CodeGen/CGExpr.cpp
clang/test/CodeGen/cfi-check-fail2.c
Index: clang/test/CodeGen/cfi-check-fail2.c
==
pcc added a comment.
__cfi_check_fail certainly seems like a special case in that its behaviour is
controlled only by flags and not the blacklist.
Maybe a simpler fix would be to add this to the top of `EmitCfiCheckFail`?
SanOpts = CGM.getLangOpts().Sanitize;
https://reviews.llvm.org/D48454
eugenis created this revision.
eugenis added reviewers: pcc, vlad.tsyrklevich.
Fixes PR37898.
https://reviews.llvm.org/D48454
Files:
clang/lib/CodeGen/CGExpr.cpp
clang/test/CodeGen/cfi-check-fail2.c
Index: clang/test/CodeGen/cfi-check-fail2.c
==
eugenis added a comment.
Another option is to add a special case to blacklist logic to make it not apply
to __cfi_check_fail.
Yet another option is to make blacklist not apply to functions without a source
location, but that seems to be done intentionally here:
http://llvm-cs.pcc.me.uk/tools/cl
