yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thank!
https://reviews.llvm.org/D48419
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
Anastasia added a comment.
In https://reviews.llvm.org/D48419#1139799, @yaxunl wrote:
> In https://reviews.llvm.org/D48419#1139749, @Anastasia wrote:
>
> > In https://reviews.llvm.org/D48419#1139601, @yaxunl wrote:
> >
> > > Did you notice the bug that C++ silently allows implicit casting of a
>
yaxunl added a comment.
In https://reviews.llvm.org/D48419#1139749, @Anastasia wrote:
> In https://reviews.llvm.org/D48419#1139601, @yaxunl wrote:
>
> > Did you notice the bug that C++ silently allows implicit casting of a
> > pointer to a pointer type with different address space?
> >
> > Do yo
Anastasia added a comment.
In https://reviews.llvm.org/D48419#1139601, @yaxunl wrote:
> Did you notice the bug that C++ silently allows implicit casting of a pointer
> to a pointer type with different address space?
>
> Do you have a fix for that?
I didn't think it did because if I run
`test
yaxunl added a comment.
Did you notice the bug that C++ silently allows implicit casting of a pointer
to a pointer type with different address space?
Do you have a fix for that?
https://reviews.llvm.org/D48419
___
cfe-commits mailing list
cfe-comm
Anastasia created this revision.
Anastasia added a reviewer: yaxunl.
Due to missing handling of address space tokens in parsing code of C++ we were
unable to parse declarations that start from an address space keyword. For
example we would get an error:
test.cl:2:1: error: expected expression
