This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE337602: [clang-doc] Adding PublicOnly flag (authored by
juliehockett, committed by ).
Herald added a subscriber: arphaman.
Changed prior to commit:
https://reviews.llvm.org/D48395?vs=154470&id=156562#
juliehockett added inline comments.
Comment at: clang-tools-extra/test/clang-doc/yaml-module.cpp:14
+// CHECK-A: ---
+// CHECK-A-NEXT: USR:
'{{[0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9
ioeric added a comment.
In https://reviews.llvm.org/D48395#1158869, @juliehockett wrote:
> Remember to mark comments as done when they are. Otherwise, LGTM unless
> @ioeric has any concerns.
No concern if this looks good to Julie.
Comment at: clang-tools-extra/test/clang-do
juliehockett accepted this revision.
juliehockett added a comment.
This revision is now accepted and ready to land.
Remember to mark comments as done when they are. Otherwise, LGTM unless @ioeric
has any concerns.
https://reviews.llvm.org/D48395
__
anniecherk updated this revision to Diff 154470.
anniecherk added a comment.
Updated according to Julie's suggestions, mostly adjusted formatting.
https://reviews.llvm.org/D48395
Files:
clang-tools-extra/clang-doc/ClangDoc.cpp
clang-tools-extra/clang-doc/ClangDoc.h
clang-tools-extra/clang
juliehockett added inline comments.
Comment at: clang-tools-extra/clang-doc/Serialize.cpp:322-324
+ if(PublicOnly && ! isPublic(D->getAccess(), D->getLinkageInternal())){
+return "";
+ }
anniecherk wrote:
> juliehockett wrote:
> > Since this is the same for
anniecherk marked 11 inline comments as done.
anniecherk added inline comments.
Comment at: clang-tools-extra/clang-doc/Serialize.cpp:322-324
+ if(PublicOnly && ! isPublic(D->getAccess(), D->getLinkageInternal())){
+return "";
+ }
juliehockett wrote:
> Sinc
juliehockett added a comment.
Please run clang-format and clang-tidy on the patch.
Comment at: clang-tools-extra/clang-doc/ClangDoc.cpp:25
#include "clang/Frontend/FrontendActions.h"
+#include "Representation.h"
Sort includes (this should be at the top)
==
anniecherk updated this revision to Diff 153825.
anniecherk marked 4 inline comments as done.
anniecherk added a comment.
Addressed Julie's comments
https://reviews.llvm.org/D48395
Files:
clang-tools-extra/clang-doc/ClangDoc.cpp
clang-tools-extra/clang-doc/ClangDoc.h
clang-tools-extra/cla
juliehockett added a reviewer: ioeric.
juliehockett added inline comments.
Comment at: clang-tools-extra/clang-doc/ClangDoc.h:27
+struct ClangDocContext {
+tooling::ExecutionContext *ECtx;
Can we put this in `Representation.h`? Here, you have a potential ci
anniecherk updated this revision to Diff 153790.
anniecherk added a comment.
Updated the tests to more accurately check that the files that we expect to not
be generated by clang-doc with the public flag are in fact not being created.
The tests now run clang-doc over the test files with and with
anniecherk updated this revision to Diff 153597.
anniecherk added a comment.
Herald added a subscriber: eraman.
- addressed Julie's comments
- updated logic to consider both access specifier & linkage
- added tests for each type of linkage
https://reviews.llvm.org/D48395
Files:
clang-tools-ex
juliehockett added a comment.
So on seeing this, all of the plumbing needed to get that particular value
where you need it is a bit ugly. I'm inclined to suggest wrapping it in a
`ClangDocContext`, containing it and the `ExecutionContext` in the `ClangDoc.h`
file:
struct ClangDocContext {
juliehockett added a comment.
Can you re-upload the patch with context? (i.e. use -U99 or similar)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48395
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
anniecherk created this revision.
anniecherk added reviewers: juliehockett, jakehehrlich, mcgrathr, phosek.
Herald added a subscriber: cfe-commits.
Added a flag which, when enabled, documents only those methods and fields which
have a Public attribute.
Repository:
rCTE Clang Tools Extra
http
15 matches
Mail list logo
