This revision was automatically updated to reflect the committed changes.
Closed by commit rL335723: [clangd] Sema ranking tweaks: downrank keywords and
injected names. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org
sammccall added a comment.
Added before/after
Comment at: clangd/Quality.cpp:160
+case Keyword: // Often relevant, but misses most signals.
+ Score *= 4; // FIXME: important keywords should have specific boosts.
break;
hokein wrote:
> I'm curi
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
The code looks good to me.
It'd be nicer if you can put ranking screenshots (before vs after) in the patch
summary.
Comment at: clangd/Quality.cpp:160
+case Keyword: /
sammccall created this revision.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ioeric, ilya-biryukov.
Injected names being ranked too high was just a bug.
The high boost for keywords was intended, but was too much given how useless
keywords are. We should probably boost them on a case-b
