[PATCH] D48357: [RISCV] Remove duplicated logic when determining the target ABI

This revision was automatically updated to reflect the committed changes. Closed by commit rL368128: [RISCV] Remove duplicated logic when determining the target ABI (authored by rogfer01, committed by ). Herald added subscribers: llvm-commits, jrtc27. Herald added a project: LLVM. Changed prior t

[PATCH] D48357: [RISCV] Remove duplicated logic when determining the target ABI

rogfer01 added a comment. Thanks @lenary ! I will commit this shortly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48357/new/ https://reviews.llvm.org/D48357 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D48357: [RISCV] Remove duplicated logic when determining the target ABI

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. Ok, sure! I think I'm happy for this to land then. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48357/new/ https://reviews.llvm.org/D48357

[PATCH] D48357: [RISCV] Remove duplicated logic when determining the target ABI

rogfer01 updated this revision to Diff 212970. rogfer01 added a comment. ChangeLog - Rebase change CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48357/new/ https://reviews.llvm.org/D48357 Files: clang/lib/Driver/ToolChains/Arch/RISCV.cpp clang/lib/Driver/ToolChains/Clang.cpp Ind

[PATCH] D48357: [RISCV] Remove duplicated logic when determining the target ABI

rogfer01 added a comment. Hi @lenary, sure I can rebase this. However, I think it may be better to do the `lp64d` change in another phab so we can keep this one NFC. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48357/new/ https://reviews.llvm.org/D48357 ___

[PATCH] D48357: [RISCV] Remove duplicated logic when determining the target ABI

lenary added a comment. Herald added subscribers: s.egerton, Jim, benna, psnobl, MaskRay. Given we now have support for the floating-point ABIs, can you rebase and update this patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48357/new/ https://reviews.llvm.org/D48357 ___

[PATCH] D48357: [RISCV] Remove duplicated logic when determining the target ABI

rogfer01 added a comment. Herald added subscribers: jocewei, PkmX, rkruppe. @asb in D59298 I call `riscv::getRISCVABI` for `ClangAs`, does it make sense to make the same change for `Clang` here? Thank you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D48357: [RISCV] Remove duplicated logic when determining the target ABI

rogfer01 added a comment. Herald added subscribers: the_o, brucehoult, MartinMosbeck. Ping? https://reviews.llvm.org/D48357 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48357: [RISCV] Remove duplicated logic when determining the target ABI

rogfer01 added inline comments. Comment at: lib/Driver/ToolChains/Arch/RISCV.cpp:381 + // FIXME: currently defaults to the soft-float ABIs. Will need to be + // expanded to select ilp32f, ilp32d, lp64f, lp64d when appropriate. When 64-bit is upstreamed and `l

[PATCH] D48357: [RISCV] Remove duplicated logic when determining the target ABI

rogfer01 created this revision. rogfer01 added a reviewer: asb. Herald added subscribers: mgrang, edward-jones, zzheng, shiva0217, kito-cheng, niosHD, sabuasal, apazos, simoncook, johnrusso, rbar. We were calculating twice ilp32/lp64. Do this just in one place instead. https://reviews.llvm.org/