[PATCH] D48341: [clang-doc] Refactoring mapper to map by scope

2018-08-02 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett marked 2 inline comments as done. juliehockett added inline comments. Comment at: clang-tools-extra/test/clang-doc/bc-linkage.cpp:106 +// CHECK-0-NEXT: +// CHECK-0-NEXT: +// CHECK-0-NEXT:blob data = 'InnerClass' ioeric wrote: > juliehockett w

[PATCH] D48341: [clang-doc] Refactoring mapper to map by scope

2018-08-02 Thread Eric Liu via Phabricator via cfe-commits
ioeric accepted this revision. ioeric added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/test/clang-doc/bc-linkage.cpp:106 +// CHECK-0-NEXT: +// CHECK-0-NEXT: +// CHECK-0-NEXT:blob data = 'InnerClass' jul

[PATCH] D48341: [clang-doc] Refactoring mapper to map by scope

2018-07-31 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/Representation.h:246 + + std::vector ChildNamespaces; + std::vector ChildRecords; ioeric wrote: > Would a record ever have namespace children? Maybe we should assert that this > doesn'

[PATCH] D48341: [clang-doc] Refactoring mapper to map by scope

2018-07-31 Thread Eric Liu via Phabricator via cfe-commits
ioeric added inline comments. Comment at: clang-tools-extra/clang-doc/Representation.cpp:49 +template +int isChildMergeNecessary(std::vector &Children, T &ChildToMerge) { + for (unsigned long I = 0; I < Children.size(); I++) { The function name doesn't describe

[PATCH] D48341: [clang-doc] Refactoring mapper to map by scope

2018-07-27 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett added a comment. any further thoughts on this? https://reviews.llvm.org/D48341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48341: [clang-doc] Refactoring mapper to map by scope

2018-07-25 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett added a comment. ping https://reviews.llvm.org/D48341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48341: [clang-doc] Refactoring mapper to map by scope

2018-07-19 Thread Eric Liu via Phabricator via cfe-commits
ioeric added inline comments. Comment at: clang-tools-extra/test/clang-doc/yaml-record.cpp:44 +// CHECK-0: --- +// CHECK-0-NEXT: USR: '06B5F6A19BA9F6A832E127C9968282B94619B210' +// CHECK-0-NEXT: Name:'C' juliehockett wrote: > ioeric wrote:

[PATCH] D48341: [clang-doc] Refactoring mapper to map by scope

2018-07-19 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett added inline comments. Herald added a subscriber: arphaman. Comment at: clang-tools-extra/test/clang-doc/yaml-record.cpp:44 +// CHECK-0: --- +// CHECK-0-NEXT: USR: '06B5F6A19BA9F6A832E127C9968282B94619B210' +// CHECK-0-NEXT: Name:'C' -

[PATCH] D48341: [clang-doc] Refactoring mapper to map by scope

2018-07-18 Thread Eric Liu via Phabricator via cfe-commits
ioeric added a comment. Map/Reduce change looks good to me. Comment at: clang-tools-extra/test/clang-doc/yaml-record.cpp:44 +// CHECK-0: --- +// CHECK-0-NEXT: USR: '06B5F6A19BA9F6A832E127C9968282B94619B210' +// CHECK-0-NEXT: Name:'C' > Y

[PATCH] D48341: [clang-doc] Refactoring mapper to map by scope

2018-07-17 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett added a comment. ping Comment at: clang-tools-extra/test/clang-doc/yaml-comments.cpp:30 +// CHECK: --- +// CHECK-NEXT: USR: '{{[0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-