ioeric added a comment.
Thanks for the refactoring and the comments! They made it a lot easier to
understand the changes.
I'm focusing on how the changes would fit into the `ToolExecutor` framework in
the review and will leave tool-specific logics to another reviewer who I assume
would know th
juliehockett added inline comments.
Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:249
+if (EnclosingScope.get().RefType == doc::InfoType::IT_function)
+ continue;
+
ioeric wrote:
> Are symbols declared in functions indexed by the tool
juliehockett updated this revision to Diff 153787.
juliehockett marked 12 inline comments as done.
juliehockett added a comment.
Refactoring second reduce code into the library, and adding bitcode
reader/writer support
https://reviews.llvm.org/D48341
Files:
clang-tools-extra/clang-doc/Bitcod
ioeric added inline comments.
Comment at: clang-tools-extra/clang-doc/Representation.h:173
bool mergeable(const Info &Other);
+ llvm::Expected getEnclosingScope();
};
Comment? What is an enclong scope?
Comment at: clang-tools-extra/clang-d
juliehockett created this revision.
juliehockett added reviewers: ioeric, lebedev.ri.
juliehockett added a project: clang-tools-extra.
The first reduce pass combines all duplicate info data into one representation
of that declaration info. This second pass iterates through the output of that
fir
