This revision was automatically updated to reflect the committed changes.
Closed by commit rL336233: [Sema] Discarded statment should be an evaluatable
context. (authored by epilk, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D48322?
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D48322#1150316, @erik.pilkington wrote:
> Is this what you were concerned about?
Yes, exactly. Thank you for checking.
Repository:
rC Clang
https://reviews.ll
erik.pilkington added a comment.
In https://reviews.llvm.org/D48322#1148424, @rsmith wrote:
> Hmm, so this will mean that we can have internal linkage declarations marked
> `Used` for which there is no definition, and we need to not warn on that.
>
> I think it might be better to avoid marking t
rsmith added a comment.
Hmm, so this will mean that we can have internal linkage declarations marked
`Used` for which there is no definition, and we need to not warn on that.
I think it might be better to avoid marking things used in this case (even
though they're still technically odr-used).
erik.pilkington added a comment.
Herald added a subscriber: dexonsmith.
Ping!
Repository:
rC Clang
https://reviews.llvm.org/D48322
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erik.pilkington created this revision.
erik.pilkington added a reviewer: rsmith.
The constexpr evaluator was erroring out because these templates weren't
defined. Despite being used in a discarded statement, we still need to
constexpr evaluate them, which means that we need to instantiate them.
