This revision was automatically updated to reflect the committed changes.
Closed by commit rL335063: [Darwin] Add a warning for missing include path for
libstdc++ (authored by arphaman, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D4
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D48297
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
arphaman updated this revision to Diff 151944.
arphaman marked 3 inline comments as done.
arphaman added a comment.
Addressed review comments
https://reviews.llvm.org/D48297
Files:
include/clang/Basic/DiagnosticFrontendKinds.td
include/clang/Lex/HeaderSearch.h
lib/Frontend/InitHeaderSearc
arphaman marked 3 inline comments as done.
arphaman added inline comments.
Comment at: lib/Frontend/InitHeaderSearch.cpp:374-377
+ IsBaseFound = AddGnuCPlusPlusIncludePaths("/usr/include/c++/4.2.1",
+"powerpc-apple-darwin10", "
vsapsai added inline comments.
Comment at: lib/Frontend/InitHeaderSearch.cpp:374-377
+ IsBaseFound = AddGnuCPlusPlusIncludePaths("/usr/include/c++/4.2.1",
+"powerpc-apple-darwin10", "",
+
arphaman added inline comments.
Comment at: lib/Frontend/InitHeaderSearch.cpp:491
} else {
- AddDefaultCPlusPlusIncludePaths(triple, HSOpts);
+ AddDefaultCPlusPlusIncludePaths(Lang, triple, HSOpts);
}
bruno wrote:
> If we happen to suggest lib
bruno added inline comments.
Comment at: lib/Frontend/InitHeaderSearch.cpp:491
} else {
- AddDefaultCPlusPlusIncludePaths(triple, HSOpts);
+ AddDefaultCPlusPlusIncludePaths(Lang, triple, HSOpts);
}
If we happen to suggest libc++, but it's also
arphaman created this revision.
arphaman added reviewers: bruno, vsapsai.
Xcode 10 removes support for libstdc++, but the users just get a confusing
include not file warning when including an STL header (when building for iOS6
which uses libstdc++ by default for example).
This patch adds a new w
