This revision was automatically updated to reflect the committed changes.
Closed by commit rL335718: [clangd] Do not show namespace comments. (authored
by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D48211
Files:
clang-too
ilya-biryukov added inline comments.
Comment at: clangd/CodeCompletionStrings.cpp:172
// get this declaration, so we don't show documentation in that case.
if (Result.Kind != CodeCompletionResult::RK_Declaration)
return "";
sammccall wrote:
> while her
ilya-biryukov updated this revision to Diff 153028.
ilya-biryukov marked an inline comment as done.
ilya-biryukov added a comment.
- Move the namespace check to happen before canRequestComment call
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48211
Files:
clangd/CodeComplet
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/CodeCompletionStrings.cpp:172
// get this declaration, so we don't show documentation in that case.
if (Result.Kind != CodeCompletionResult
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: sammccall.
Herald added subscribers: jkorous, MaskRay, ioeric.
Comments from namespaces that clangd produces are too noisy and often
not useful.
Namespaces have too many redecls and we don't have a good way of
determining which
