[PATCH] D48098: clang-format-diff: Switch to python3 by default, support python 2.7

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Checked with both python 2 and python 3 as suggested. Works like a charm! Thank you! https://reviews.llvm.org/D48098 ___ cfe-commits mailing

[PATCH] D48098: clang-format-diff: Switch to python3 by default, support python 2.7

MarcoFalke updated this revision to Diff 152867. MarcoFalke added a comment. Keep python2 by default for now https://reviews.llvm.org/D48098 Files: tools/clang-format/clang-format-diff.py Index: tools/clang-format/clang-format-diff.py

[PATCH] D48098: clang-format-diff: Switch to python3 by default, support python 2.7

krasimir added inline comments. Comment at: tools/clang-format/clang-format-diff.py:1 -#!/usr/bin/env python +#!/usr/bin/env python3 # lebedev.ri wrote: > Why do you need to *switch* the default? > What's wrong with [at least starting with] just making sure it w

[PATCH] D48098: clang-format-diff: Switch to python3 by default, support python 2.7

lebedev.ri added a comment. Please always upload all patches with the full context (`-U9`) Comment at: tools/clang-format/clang-format-diff.py:1 -#!/usr/bin/env python +#!/usr/bin/env python3 # Why do you need to *switch* the default? What's wrong with [at

[PATCH] D48098: clang-format-diff: Switch to python3 by default, support python 2.7

MarcoFalke updated this revision to Diff 151260. MarcoFalke edited the summary of this revision. https://reviews.llvm.org/D48098 Files: tools/clang-format/clang-format-diff.py Index: tools/clang-format/clang-format-diff.py === --

[PATCH] D48098: clang-format-diff: Switch to python3 by default, support python 2.7

MarcoFalke added a comment. > why is this switch necessary? It is not necessary, but would be nice if the script run on python3 as well (as opposed to only python2, which is going to be deprecated https://pythonclock.org/) > what's expected to be supported with it? I'd assume python2.7 (w

[PATCH] D48098: clang-format-diff: Switch to python3 by default, support python 2.7

krasimir requested changes to this revision. krasimir added a comment. This revision now requires changes to proceed. Sorry, I'm not familiar with this tool. Could you elaborate: - why is this switch necessary? - what's expected to be supported with it? - how do I test it? https://reviews.llvm.

[PATCH] D48098: clang-format-diff: Switch to python3 by default, support python 2.7

MarcoFalke updated this revision to Diff 151038. MarcoFalke added a comment. In python2.7: TypeError: 'encoding' is an invalid keyword argument for this function So remove it for now. https://reviews.llvm.org/D48098 Files: tools/clang-format/clang-format-diff.py Index: tools/clang-format/c

[PATCH] D48098: clang-format-diff: Switch to python3 by default, support python 2.7

MarcoFalke created this revision. Repository: rC Clang https://reviews.llvm.org/D48098 Files: tools/clang-format/clang-format-diff.py Index: tools/clang-format/clang-format-diff.py === --- tools/clang-format/clang-format-diff.