[PATCH] D48036: [CUDA] Make min/max shims host+device.

2018-06-29 Thread Justin Lebar via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL336025: [CUDA] Make min/max shims host+device. (authored by jlebar, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D48036?vs=150790&id=153593#

[PATCH] D48036: [CUDA] Make min/max shims host+device.

2018-06-29 Thread Justin Lebar via Phabricator via cfe-commits
jlebar added a comment. > Looks right to me (other than the missing constexpr in C++14 onwards). Though > this is subtle enough that I suspect the only way to know for sure is to try > it. Thanks a lot, Richard. FTR the missing constexpr is in https://reviews.llvm.org/D48151. https://review

[PATCH] D48036: [CUDA] Make min/max shims host+device.

2018-06-29 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks right to me (other than the missing `constexpr` in C++14 onwards). Though this is subtle enough that I suspect the only way to know for sure is to try it. https://reviews.llvm.org/D4803

[PATCH] D48036: [CUDA] Make min/max shims host+device.

2018-06-25 Thread Justin Lebar via Phabricator via cfe-commits
jlebar added a comment. @rsmith friendly ping on this one. https://reviews.llvm.org/D48036 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48036: [CUDA] Make min/max shims host+device.

2018-06-15 Thread Justin Lebar via Phabricator via cfe-commits
jlebar added a comment. @rsmith friendly ping on this one. https://reviews.llvm.org/D48036 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48036: [CUDA] Make min/max shims host+device.

2018-06-13 Thread Justin Lebar via Phabricator via cfe-commits
jlebar added a comment. In https://reviews.llvm.org/D48036#1131279, @tra wrote: > Ack. Patches sent (see dependency chain in phab). https://reviews.llvm.org/D48036 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D48036: [CUDA] Make min/max shims host+device.

2018-06-13 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. Ack. https://reviews.llvm.org/D48036 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48036: [CUDA] Make min/max shims host+device.

2018-06-13 Thread Justin Lebar via Phabricator via cfe-commits
jlebar added a comment. > Last comment in the bug pointed out that those overloads should be constexpr > in c++14. Maybe in a separate patch, though. Yeah, would prefer to do it in a separate patch. It's possible that having constexpr min/max in C++14 mode *without a C++14 standard library* wi

[PATCH] D48036: [CUDA] Make min/max shims host+device.

2018-06-12 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. Last comment in the bug pointed out that those overloads should be constexpr in c++14. Maybe in a separate patch, though. https://bugs.llvm.org/show_bug.cgi?id=37753#c5 https://reviews.llvm.org/D48036 ___ cfe-commits mailing l

[PATCH] D48036: [CUDA] Make min/max shims host+device.

2018-06-11 Thread Justin Lebar via Phabricator via cfe-commits
jlebar created this revision. jlebar added a reviewer: rsmith. Herald added a subscriber: sanjoy. Fixes PR37753: min/max can't be called from __host__ __device__ functions in C++14 mode. Testcase in a separate test-suite commit. https://reviews.llvm.org/D48036 Files: clang/lib/Headers/cuda_w