[PATCH] D47987: Provide only one declaration of __throw_runtime_error

2019-10-18 Thread Dimitry Andric via Phabricator via cfe-commits
dim abandoned this revision. dim added a comment. Herald added a subscriber: libcxx-commits. Obsoleted by D58425 (and rCXX354515 ). Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47987/new/

[PATCH] D47987: Provide only one declaration of __throw_runtime_error

2018-08-14 Thread Aditya Kumar via Phabricator via cfe-commits
hiraditya added a comment. Herald added a subscriber: ldionne. Any updates on this one? I like @mclow.lists idea of removing it from __locale. Repository: rCXX libc++ https://reviews.llvm.org/D47987 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D47987: Provide only one declaration of __throw_runtime_error

2018-06-14 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists added a comment. I'm not really happy with gcc's redundant declaration warnings; I think they're "nannying" rather than useful. That being said, why not just remove the declaration in `__locale`? `__locale` includes `string`, which includes `stdexcept`. Repository: rCXX libc++ h

[PATCH] D47987: Provide only one declaration of __throw_runtime_error

2018-06-09 Thread Dimitry Andric via Phabricator via cfe-commits
dim created this revision. dim added reviewers: hiraditya, mclow.lists, EricWF. Herald added subscribers: christof, krytarowski, emaste. In https://reviews.llvm.org/rL279903, @hiraditya added a second declaration of `__throw_runtime_error` to `include/__locale`. The original declaration was in `_