This revision was automatically updated to reflect the committed changes.
sammccall marked an inline comment as done.
Closed by commit rCTE334822: [clangd] Add option to fold overloads into a
single completion item. (authored by sammccall, committed by ).
Changed prior to commit:
https://review
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM. (and a question on why we want to special-case the members)
Comment at: clangd/CodeComplete.cpp:245
+// Methods are simply grouped by name.
+
sammccall updated this revision to Diff 151476.
sammccall marked an inline comment as done.
sammccall added a comment.
Review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47957
Files:
clangd/CodeComplete.cpp
clangd/CodeComplete.h
clangd/tool/ClangdMain.cpp
un
sammccall marked 4 inline comments as done.
sammccall added inline comments.
Comment at: clangd/CodeComplete.cpp:245
+// Methods are simply grouped by name.
+return hash_combine('M', IndexResult->Name);
+ case index::SymbolKind::Function:
ily
ilya-biryukov added a comment.
Overall LG. It would be nice to mention somewhere that we since we bundle
overloads client-side we might run into weird side-effects (e.g. return less
completion items than the specified limit) in case the index returns too many
non-bundled.
Co
ilya-biryukov added a comment.
Oh, sorry, I forgot to submit the comments yesterday :-(
Comment at: clangd/CodeComplete.cpp:245
+// Methods are simply grouped by name.
+return hash_combine('M', IndexResult->Name);
+ case index::SymbolKind::Function:
---
sammccall added a comment.
Plan regarding hiding signatures, and configuration:
- internally, keep these options independent (programmatic users know what
they're doing)
- as a CLI flag, make it a tristate (detailed/bundled/simple), because !Bundle
&& !Signatures doesn't make sense.
Not 100% s
sammccall updated this revision to Diff 151316.
sammccall added a comment.
Give ScoredBundleGreater a better name/location.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47957
Files:
clangd/CodeComplete.cpp
clangd/CodeComplete.h
clangd/tool/ClangdMain.cpp
unittests/cla
