[PATCH] D47956: [MS] Consder constexpr globals to be inline, as in C++17

This revision was automatically updated to reflect the committed changes. Closed by commit rL371642: [MS] Consder constexpr globals to be inline, as in C++17 (authored by rnk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[PATCH] D47956: [MS] Consder constexpr globals to be inline, as in C++17

rnk added a comment. In D47956#1138555 , @rnk wrote: > In D47956#1138521 , @rsmith wrote: > > > Can we now remove the corresponding MSVC-specific hacks elsewhere (eg, > > `ASTContext::isMSStaticDataMemberInlineDefi

[PATCH] D47956: [MS] Consder constexpr globals to be inline, as in C++17

rnk updated this revision to Diff 219638. rnk added a comment. Herald added a subscriber: mstorsjo. Herald added a project: clang. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47956/new/ https://reviews.llvm.org/D47956 Files: clang/lib

[PATCH] D47956: [MS] Consder constexpr globals to be inline, as in C++17

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks for explaining, makes sense to me. https://reviews.llvm.org/D47956 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

[PATCH] D47956: [MS] Consder constexpr globals to be inline, as in C++17

rnk added a comment. In https://reviews.llvm.org/D47956#1138521, @rsmith wrote: > Can we now remove the corresponding MSVC-specific hacks elsewhere (eg, > `ASTContext::isMSStaticDataMemberInlineDefinition`), or do we still need > those for `const`-but-not-`constexpr` static data members? We s

[PATCH] D47956: [MS] Consder constexpr globals to be inline, as in C++17

rsmith added a comment. Can we now remove the corresponding MSVC-specific hacks elsewhere (eg, `ASTContext::isMSStaticDataMemberInlineDefinition`), or do we still need those for `const`-but-not-`constexpr` static data members? https://reviews.llvm.org/D47956

[PATCH] D47956: [MS] Consder constexpr globals to be inline, as in C++17

rnk added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:6597 + (getLangOpts().CPlusPlus17 || + Context.getTargetInfo().getCXXABI().isMicrosoft())) NewVD->setImplicitlyInline(); thakis wrote: > Is this related to /Zc:externCo

[PATCH] D47956: [MS] Consder constexpr globals to be inline, as in C++17

thakis added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:6597 + (getLangOpts().CPlusPlus17 || + Context.getTargetInfo().getCXXABI().isMicrosoft())) NewVD->setImplicitlyInline(); Is this related to /Zc:externConstexpr / PR3

[PATCH] D47956: [MS] Consder constexpr globals to be inline, as in C++17

rnk created this revision. rnk added a reviewer: thakis. Microsoft seems to do this regardless of the language mode, so we must also do it in order to be ABI compatible. Fixes PR36125 https://reviews.llvm.org/D47956 Files: clang/lib/Sema/SemaDecl.cpp clang/test/CXX/dcl.dcl/dcl.spec/dcl.con