[PATCH] D47912: [CMake] Consider LLVM_APPEND_VC_REV when generating SVNVersion.inc

2018-09-09 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. Sorry for the late comment... Are you amending an llvm commit or a clang commit? The reason I ask is that if I amend an llvm commit, I have to update around 78 targets (llvm + clang + libcxx + libcxxabi + libunwind), but if I amend a clang commit, I only have to upda

[PATCH] D47912: [CMake] Consider LLVM_APPEND_VC_REV when generating SVNVersion.inc

2018-06-07 Thread Gabor Buella via Phabricator via cfe-commits
GBuella added a comment. In https://reviews.llvm.org/D47912#1125803, @smeenai wrote: > I believe LLVM_APPEND_VC_REV controls whether the revision is appended to > LLVM version string (e.g. the output of `llvm-config --version`), whereas the > SVNRevision.inc file (which is what's causing the re

[PATCH] D47912: [CMake] Consider LLVM_APPEND_VC_REV when generating SVNVersion.inc

2018-06-07 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. I believe LLVM_APPEND_VC_REV controls whether the revision is appended to LLVM version string (e.g. the output of `llvm-config --version`), whereas the SVNRevision.inc file (which is what's causing the relink after amending) is used for e.g. the `clang --version` output

[PATCH] D47912: [CMake] Consider LLVM_APPEND_VC_REV when generating SVNVersion.inc

2018-06-07 Thread Gabor Buella via Phabricator via cfe-commits
GBuella created this revision. GBuella added reviewers: beanz, bogner, hintonda. Herald added subscribers: cfe-commits, mgorny. This is merely a quickfix, due to being fustrated with waiting for ~70 objects to be linked each time following `git commit --amend`. When toggling LLVM_APPEND_VC_REV bet