[PATCH] D47896: [CodeComplete] suppress define X X macros

2018-06-08 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Going to put this on hold until someone actually reports the bug. Repository: rC Clang https://reviews.llvm.org/D47896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D47896: [CodeComplete] suppress define X X macros

2018-06-08 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. In https://reviews.llvm.org/D47896#1126171, @sammccall wrote: > Hmm, musl does `#define stderr (stderr)` :-( And they discussed #define > stderr (stderr+0). > (To enforce it's not assigned to etc) > https://github.com/cloudius-systems/musl/blob/master/include/std

[PATCH] D47896: [CodeComplete] suppress define X X macros

2018-06-08 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Hmm, musl does `#define stderr (stderr)` :-( And they discussed #define stderr (stderr+0). (To enforce it's not assigned to etc) https://github.com/cloudius-systems/musl/blob/master/include/stdio.h#L61 Ilya also pointed out offline the windows API convention: CreateFil

[PATCH] D47896: [CodeComplete] suppress define X X macros

2018-06-07 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added a subscriber: cfe-commits. In particular, stderr etc where the equivalent symbols exist in the global namespace. Having the symbol instead of the macro helps with ranking, and avoids the current duplicate stde