[PATCH] D47887: Move VersionTuple from clang/Basic to llvm/Support, llvm part

2018-06-11 Thread Pavel Labath via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL334399: Move VersionTuple from clang/Basic to llvm/Support (authored by labath, committed by ). Changed prior to commit: https://reviews.llvm.org/D47887?vs=150339&id=150701#toc Repository: rL LLVM h

[PATCH] D47887: Move VersionTuple from clang/Basic to llvm/Support, llvm part

2018-06-08 Thread Erik Pilkington via Phabricator via cfe-commits
erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM, thanks for adding the test! Repository: rL LLVM https://reviews.llvm.org/D47887 ___ cfe-commits mailing list cfe-commi

[PATCH] D47887: Move VersionTuple from clang/Basic to llvm/Support, llvm part

2018-06-07 Thread Pavel Labath via Phabricator via cfe-commits
labath added a comment. Yea, one day I'll have to try that out. I'm just putting it off cause it would nuke all my branches and build folders :/ FWIW, the llvm part can actually be committed without breaking clang or anyone. Repository: rL LLVM https://reviews.llvm.org/D47887 ___

[PATCH] D47887: Move VersionTuple from clang/Basic to llvm/Support, llvm part

2018-06-07 Thread Zachary Turner via Phabricator via cfe-commits
zturner added a comment. It would be better if you're using a monorepo, that way both parts can just be one single patch. Repository: rL LLVM https://reviews.llvm.org/D47887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

[PATCH] D47887: Move VersionTuple from clang/Basic to llvm/Support, llvm part

2018-06-07 Thread Pavel Labath via Phabricator via cfe-commits
labath created this revision. labath added reviewers: zturner, erik.pilkington. Herald added a subscriber: mgorny. This kind of functionality is useful to other project apart from clang. LLDB works with version numbers a lot, but it does not have a convenient abstraction for this. Moving this clas