[PATCH] D47869: [clangd] Fix using the incorrect Index for go-to-definition.

2018-06-07 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rCTE334176: [clangd] Fix using the incorrect Index for go-to-definition. (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D47

[PATCH] D47869: [clangd] Fix using the incorrect Index for go-to-definition.

2018-06-07 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 150276. hokein added a comment. this->Index => Index. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47869 Files: clangd/ClangdServer.cpp Index: clangd/ClangdServer.cpp ===

[PATCH] D47869: [clangd] Fix using the incorrect Index for go-to-definition.

2018-06-07 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clangd/ClangdServer.cpp:305 return CB(InpAST.takeError()); -CB(clangd::findDefinitions(InpAST->AST, Pos, this->FileIdx.get())); +CB(clang

[PATCH] D47869: [clangd] Fix using the incorrect Index for go-to-definition.

2018-06-07 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: jkorous, MaskRay, ioeric, ilya-biryukov. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47869 Files: clangd/ClangdServer.cpp Index: clangd/ClangdServer.cpp