This revision was automatically updated to reflect the committed changes.
Closed by commit rL335282: [bindings] Fix most Python binding unittests on
Windows (authored by jbcoe, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D47864
Files:
ethanhs added a comment.
In https://reviews.llvm.org/D47864#1139750, @jbcoe wrote:
> Would you like me to commit this for you?
Sure, that would be great! I don't have commit rights so I was waiting for
someone to do it. Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D47864
_
jbcoe added a comment.
Would you like me to commit this for you?
Repository:
rC Clang
https://reviews.llvm.org/D47864
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ethanhs added a comment.
In https://reviews.llvm.org/D47864#1124948, @bkramer wrote:
> I don't know much about the python bindings, but this is probably fine.
Yeah I wasn't really sure who to add so I looked at the commit history. Thank
you for adding the right people.
Repository:
rC Clang
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
I don't know much about the python bindings, but this is probably fine.
Repository:
rC Clang
https://reviews.llvm.org/D47864
___
cfe-commits
ethanhs created this revision.
ethanhs added a reviewer: bkramer.
Herald added a subscriber: cfe-commits.
This fixes all but one of the test cases for Windows. TestCDB will
take more work to debug, as CompilationDatabase seems not to work correctly.
Repository:
rC Clang
https://reviews.llvm.o
