This revision was automatically updated to reflect the committed changes.
Closed by commit rC334253: [CodeGen] Always use MSVC personality for
windows-msvc targets (authored by smeenai, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47862?vs=150243&id=150437#toc
Repository:
rnk accepted this revision.
rnk added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/CodeGen/CGException.cpp:134-135
const llvm::Triple &T = Target.getTriple();
+ if (T.isWindowsMSVCEnvironment())
+return EHPersonality::MSVC_CxxFrameHand
smeenai added inline comments.
Comment at: lib/CodeGen/CGException.cpp:134-135
const llvm::Triple &T = Target.getTriple();
+ if (T.isWindowsMSVCEnvironment())
+return EHPersonality::MSVC_CxxFrameHandler3;
+
rnk wrote:
> I guess previously we carefully arr
rnk added inline comments.
Comment at: lib/CodeGen/CGException.cpp:134-135
const llvm::Triple &T = Target.getTriple();
+ if (T.isWindowsMSVCEnvironment())
+return EHPersonality::MSVC_CxxFrameHandler3;
+
I guess previously we carefully arranged to go to wh
smeenai created this revision.
smeenai added reviewers: compnerd, DHowett-MSFT, rnk.
The windows-msvc target is meant to be ABI compatible with MSVC,
including the exception handling. Ensure that a windows-msvc triple
always equates to the MSVC personality being used.
This mostly affects the GNUS
