This revision was automatically updated to reflect the committed changes.
Closed by commit rL334162: [clangd] Make workspace/symbols actually rank its
results. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D478
sammccall added inline comments.
Comment at: clangd/FindSymbols.cpp:20
+#define DEBUG_TYPE "FindSymbols"
+
malaperle wrote:
> nit: I don't think this is used. Remove?
This is consumed by the LLVM_DEBUG macro. You can enable program-wide debug
output with -debu
malaperle added a comment.
This works much better! Just a nit.
Comment at: clangd/FindSymbols.cpp:20
+#define DEBUG_TYPE "FindSymbols"
+
nit: I don't think this is used. Remove?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47821
__
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: clangd/FindSymbols.cpp:159
+else
+ return;
+Relevance.merge(Sym);
Should we add a log statement here? IMO, this rarely happens
sammccall created this revision.
sammccall added a reviewer: hokein.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ioeric, ilya-biryukov.
The index doesn't actually return results in ranked order.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47821
Files:
clangd/F
