[PATCH] D47817: [compiler-rt] [sanitizer_common] Fix using libtirpc on Linux

2018-12-24 Thread Kamil Rytarowski via Phabricator via cfe-commits
krytarowski added a comment. If libtirpc is from an external library we shall not sanitize it. If it is a part of libc (on glibc? on solaris?) it shall be sanitized only there. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47817/new/ https://reviews.llvm.org/D47817 _

[PATCH] D47817: [compiler-rt] [sanitizer_common] Fix using libtirpc on Linux

2018-12-24 Thread Michał Górny via Phabricator via cfe-commits
mgorny updated this revision to Diff 179460. mgorny added a comment. Herald added subscribers: srhines, emaste. Updated as requested by @Lekensteyn CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47817/new/ https://reviews.llvm.org/D47817 Files: cmake/Modules/FindLibtirpc.cmake lib/s

[PATCH] D47817: [compiler-rt] [sanitizer_common] Fix using libtirpc on Linux

2018-12-23 Thread Peter Wu via Phabricator via cfe-commits
Lekensteyn added a comment. There appears to be other definitions for HAVE_TIRPC_RPC_XDR_H in lib/sanitizer_common/sanitizer_platform.h lib/sanitizer_common/sanitizer_platform_limits_freebsd.cc While at it, perhaps the `#if HAVE_FOO` could be replaced by `#ifdef HAVE_FOO`? CHANGES SINCE LAST AC

[PATCH] D47817: [compiler-rt] [sanitizer_common] Fix using libtirpc on Linux

2018-12-23 Thread Michał Górny via Phabricator via cfe-commits
mgorny updated this revision to Diff 179453. mgorny retitled this revision from "[sanitizer_common] Fix using libtirpc on Linux" to "[compiler-rt] [sanitizer_common] Fix using libtirpc on Linux". mgorny edited the summary of this revision. mgorny added a reviewer: Lekensteyn. mgorny added a commen