This revision was automatically updated to reflect the committed changes.
Closed by commit rL334457: [CUDA][HIP] Set kernel calling convention before
arrange function (authored by yaxunl, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Ok.
https://reviews.llvm.org/D47733
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
yaxunl updated this revision to Diff 150559.
yaxunl marked an inline comment as done.
yaxunl added a comment.
Wrap long RUN lines in test.
https://reviews.llvm.org/D47733
Files:
lib/CodeGen/CGCall.cpp
lib/CodeGen/CodeGenModule.cpp
lib/CodeGen/TargetInfo.cpp
lib/CodeGen/TargetInfo.h
te
tra added a comment.
@rsmith - Richard, can you take a look?
Comment at: test/CodeGenCUDA/kernel-args.cu:1-2
+// RUN: %clang_cc1 -triple amdgcn-amd-amdhsa -fcuda-is-device -emit-llvm %s -o
- | FileCheck -check-prefix=AMDGCN %s
+// RUN: %clang_cc1 -triple nvptx64-nvidia-cuda- -
yaxunl updated this revision to Diff 150106.
yaxunl added a comment.
Revised by Artem's comments.
https://reviews.llvm.org/D47733
Files:
lib/CodeGen/CGCall.cpp
lib/CodeGen/CodeGenModule.cpp
lib/CodeGen/TargetInfo.cpp
lib/CodeGen/TargetInfo.h
test/CodeGenCUDA/kernel-args.cu
Index: tes
tra added a comment.
Looks OK overall, but I'm not very familiar with CGCall, so you may want to dig
through the history and find someone with more expertise.
Comment at: test/CodeGenCUDA/kernel-args-amdgcn.cu:1
+// RUN: %clang_cc1 -triple amdgcn-amd-amdhsa -fcuda-is-device -e
yaxunl created this revision.
yaxunl added reviewers: rjmccall, tra.
Currently clang set kernel calling convention for CUDA/HIP after
arranging function, which causes incorrect kernel function type since
it depends on calling convention.
This patch moves setting kernel convention before arranging
