[PATCH] D47720: [DebugInfo] Inline for without DebugLocation

This revision was automatically updated to reflect the committed changes. Closed by commit rL335255: [DebugInfo] Inline for without DebugLocation (authored by gramanas, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D47720 Files: cfe/tr

[PATCH] D47720: [DebugInfo] Inline for without DebugLocation

probinson added a comment. In https://reviews.llvm.org/D47720#1136585, @gramanas wrote: > ping! should I commit this? @vsk accepted it, so yes go ahead. Repository: rC Clang https://reviews.llvm.org/D47720 ___ cfe-commits mailing list cfe-comm

[PATCH] D47720: [DebugInfo] Inline for without DebugLocation

gramanas added a comment. ping! should I commit this? Repository: rC Clang https://reviews.llvm.org/D47720 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47720: [DebugInfo] Inline for without DebugLocation

gramanas updated this revision to Diff 150135. gramanas added a comment. make code more readable Repository: rC Clang https://reviews.llvm.org/D47720 Files: lib/CodeGen/CGExprScalar.cpp test/CodeGen/debug-info-inline-for.c Index: test/CodeGen/debug-info-inline-for.c ===

[PATCH] D47720: [DebugInfo] Inline for without DebugLocation

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. As is the case with https://reviews.llvm.org/D47097, this helps preserve more scope information after SROA. LGTM. Thanks! Repository: rC Clang https://reviews.llvm.org/D47720

[PATCH] D47720: [DebugInfo] Inline for without DebugLocation

gramanas added inline comments. Comment at: test/CodeGen/debug-info-inline-for.c:13 + +// CHECK: ![[DbgLoc]] = !DILocation( aprantl wrote: > Shouldn't you also check *which* location is attached to it? I wasn't sure if this should be an artificial location or not

[PATCH] D47720: [DebugInfo] Inline for without DebugLocation

gramanas updated this revision to Diff 150036. gramanas marked an inline comment as done. gramanas added a comment. Add artificial debug location to the phi instruction Repository: rC Clang https://reviews.llvm.org/D47720 Files: lib/CodeGen/CGExprScalar.cpp test/CodeGen/debug-info-inline

[PATCH] D47720: [DebugInfo] Inline for without DebugLocation

aprantl added inline comments. Comment at: test/CodeGen/debug-info-inline-for.c:13 + +// CHECK: ![[DbgLoc]] = !DILocation( Shouldn't you also check *which* location is attached to it? Repository: rC Clang https://reviews.llvm.org/D47720 __

[PATCH] D47720: [DebugInfo] Inline for without DebugLocation

gramanas updated this revision to Diff 149996. gramanas added a comment. Add comment explaining the test Repository: rC Clang https://reviews.llvm.org/D47720 Files: test/CodeGen/debug-info-inline-for.c Index: test/CodeGen/debug-info-inline-for.c ==

[PATCH] D47720: [DebugInfo] Inline for without DebugLocation

aprantl added inline comments. Comment at: test/CodeGen/debug-info-inline-for.c:2 +// RUN: %clang_cc1 -debug-info-kind=limited -emit-llvm -o - %s | FileCheck %s + +int func(int n) { Please add a comment explaining what is being tested here. Repository: rC Cla

[PATCH] D47720: [DebugInfo] Inline for without DebugLocation

gramanas created this revision. gramanas added a reviewer: vsk. Herald added subscribers: cfe-commits, JDevlieghere, eraman, aprantl. This test is a strip down version of a function inside the amalgamated sqlite source. When converted to IR clang produces a phi instruction without debug location.