This revision was automatically updated to reflect the committed changes.
Closed by commit rL334224: [Parse] Use CapturedStmt for @finally on MSVC
(authored by smeenai, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D47564
Files:
cfe/tr
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Okay, We can try this, then.
Repository:
rC Clang
https://reviews.llvm.org/D47564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
smeenai added a comment.
In https://reviews.llvm.org/D47564#1119925, @rjmccall wrote:
> In https://reviews.llvm.org/D47564#1119874, @smeenai wrote:
>
> > In https://reviews.llvm.org/D47564#1118424, @rjmccall wrote:
> >
> > > No, it was just a general question. Have you gotten this to a point
>
rjmccall added a comment.
In https://reviews.llvm.org/D47564#1119874, @smeenai wrote:
> In https://reviews.llvm.org/D47564#1118424, @rjmccall wrote:
>
> > No, it was just a general question. Have you gotten this to a point where
> > it's testable?
>
>
> Yup, it's been working fine in my local t
smeenai added a comment.
In https://reviews.llvm.org/D47564#1118424, @rjmccall wrote:
> In https://reviews.llvm.org/D47564#1118423, @smeenai wrote:
>
> > In https://reviews.llvm.org/D47564#1118381, @rjmccall wrote:
> >
> > > That's an interesting idea. I don't see any particular reason not to do
rjmccall added a comment.
In https://reviews.llvm.org/D47564#1118423, @smeenai wrote:
> In https://reviews.llvm.org/D47564#1118381, @rjmccall wrote:
>
> > That's an interesting idea. I don't see any particular reason not to do it
> > this way if you're willing to accept that it's never going to
smeenai added a comment.
In https://reviews.llvm.org/D47564#1118381, @rjmccall wrote:
> That's an interesting idea. I don't see any particular reason not to do it
> this way if you're willing to accept that it's never going to support the
> full control-flow possibilities of @finally. You wil
rjmccall added a comment.
That's an interesting idea. I don't see any particular reason not to do it
this way if you're willing to accept that it's never going to support the full
control-flow possibilities of @finally. You will need to add JumpDiagnostics
logic to prevent branches out of the
smeenai updated this revision to Diff 149351.
smeenai edited the summary of this revision.
smeenai added a comment.
@rnk comment
Repository:
rC Clang
https://reviews.llvm.org/D47564
Files:
include/clang/AST/Stmt.h
include/clang/Basic/CapturedStmt.h
include/clang/Sema/ScopeInfo.h
lib/
rnk added a comment.
Using CapturedStmt to do frontend outlining was the direction I suggested. I
want to hear what @rsmith and @rjmccall think, though.
Comment at: lib/Parse/ParseObjc.cpp:2588
+ bool ShouldCapture = Actions.getASTContext()
+
smeenai updated this revision to Diff 149220.
smeenai added a comment.
Proper diff
Repository:
rC Clang
https://reviews.llvm.org/D47564
Files:
include/clang/AST/Stmt.h
include/clang/Basic/CapturedStmt.h
include/clang/Sema/ScopeInfo.h
lib/Parse/ParseObjc.cpp
test/SemaObjC/finally-ms
smeenai created this revision.
smeenai added reviewers: rjmccall, rnk, rsmith.
Herald added a subscriber: cfe-commits.
The body of a @finally needs to be executed on both exceptional and
non-exceptional paths. On landingpad platforms, this is straightforward:
the @finally body is emitted as a norm
12 matches
Mail list logo
