[PATCH] D47480: clang-cl: Expose -no-canonical-prefixes

thakis marked 2 inline comments as done. thakis added inline comments. Comment at: test/Driver/cl-options.c:595 +// RUN: -no-canonical-prefixes \ +// RUN: -fno-coverage-mapping \ // RUN: --version \ rnk wrote: > takuto.ikuta wrote: > > Is this relate

[PATCH] D47480: clang-cl: Expose -no-canonical-prefixes

thakis closed this revision. thakis added a comment. r333761, thanks! https://reviews.llvm.org/D47480 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47480: clang-cl: Expose -no-canonical-prefixes

takuto.ikuta accepted this revision. takuto.ikuta added a comment. I confirmed this CL and https://reviews.llvm.org/D47578 remove absolute path from /showIncludes when include paths are given in relative. https://reviews.llvm.org/D47480 ___ cfe-com

[PATCH] D47480: clang-cl: Expose -no-canonical-prefixes

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: test/Driver/cl-options.c:595 +// RUN: -no-canonical-prefixes \ +// RUN: -fno-coverage-mapping \ // RUN: --version \ takuto.ikuta wrot

[PATCH] D47480: clang-cl: Expose -no-canonical-prefixes

takuto.ikuta added a comment. GetExecutablePath is called here. http://llvm-cs.pcc.me.uk/tools/clang/tools/driver/driver.cpp#427 You'll understand what I said if you see the behavior of clang-cl on windows. Comment at: test/Driver/cl-options.c:595 +// RUN: -no-canonical-pr

[PATCH] D47480: clang-cl: Expose -no-canonical-prefixes

thakis added a subscriber: rnk. thakis added a comment. But GetExecutablePath isn't called if -no-canonical-prefixes is passed, is it? (See the first link I pasted above) https://reviews.llvm.org/D47480 ___ cfe-commits mailing list cfe-commits@lists

Re: [PATCH] D47480: clang-cl: Expose -no-canonical-prefixes

But GetExecutablePath isn't called if -no-canonical-prefixes is passed, is it? (See the first link I pasted above) On Tue, May 29, 2018, 5:28 PM Takuto Ikuta via Phabricator via cfe-commits < cfe-commits@lists.llvm.org> wrote: > takuto.ikuta added a comment. > > On windows, argv0 is changed to ab

[PATCH] D47480: clang-cl: Expose -no-canonical-prefixes

takuto.ikuta added a comment. On windows, argv0 is changed to absolute path before we call GetExecutablePath. That makes resource-dir absolute. I need clang-cl on windows has relative --resource-dir. See around heres. https://github.com/llvm-project/llvm-project-20170507/blob/83b39c10b1d7a9189b7e

[PATCH] D47480: clang-cl: Expose -no-canonical-prefixes

thakis added a comment. I did test this locally before sending it out, and the -resource-dir arg passed to cc1 is relative with this patch: $ bin/clang-cl -no-canonical-prefixes -c test.cc -### clang version 7.0.0 Target: x86_64-pc-windows-msvc Thread model: posix InstalledDir: bin

[PATCH] D47480: clang-cl: Expose -no-canonical-prefixes

takuto.ikuta added a comment. Thank you for quick supporting, but this is not sufficient for clang-cl on windows. llvm::InitLLVM calls windows::GetCommandLineArguments, and argv0 is changed to absolute path. https://github.com/llvm-project/llvm-project-20170507/blob/7c81daae49eaf7f9681457b46c56

[PATCH] D47480: clang-cl: Expose -no-canonical-prefixes

thakis created this revision. thakis added a reviewer: rnk. -no-canonical-prefixes is a weird flag: In gcc, it controls whether realpath() is called on the path of the driver binary. It's needed to support some usecases where gcc is symlinked to, see https://gcc.gnu.org/ml/gcc/2011-01/msg00429.