aaron.ballman closed this revision.
aaron.ballman added a comment.
I've committed in r335048; if @rsmith has concerns, they can be address post
commit.
https://reviews.llvm.org/D47435
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.
Looks good to me, but you probably want a bit for a second opinion.
https://reviews.llvm.org/D47435
___
cfe-commits mailing list
cfe-comm
aaron.ballman added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:925
+ case Builtin::BI__builtin_signbitl:
if (SemaBuiltinFPClassification(TheCall, 1))
return ExprError();
lebedev.ri wrote:
> The name of the function is unfortunate given th
aaron.ballman updated this revision to Diff 150967.
aaron.ballman marked 5 inline comments as done.
aaron.ballman added a comment.
Updating based on review feedback.
https://reviews.llvm.org/D47435
Files:
lib/Sema/SemaChecking.cpp
test/Sema/builtins.c
Index: test/Sema/builtins.c
=
lebedev.ri added a comment.
The checking by itself looks sane-ish, but i don't have any reasonable
knowledge in this area.
Comment at: lib/Sema/SemaChecking.cpp:925
+ case Builtin::BI__builtin_signbitl:
if (SemaBuiltinFPClassification(TheCall, 1))
return ExprError
aaron.ballman added a comment.
Ping
Repository:
rC Clang
https://reviews.llvm.org/D47435
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added inline comments.
Comment at: test/Sema/builtins.c:228
// expected-note {{change size argument to
be the size of the destination}}
-
+
__builtin___strlcat_chk(buf, b, sizeof(b), _
aaron.ballman created this revision.
aaron.ballman added reviewers: rengolin, chatur01, rsmith.
aaron.ballman added inline comments.
Comment at: test/Sema/builtins.c:228
// expected-note {{change size argument to
be the size of the destinatio
